Integrated: 8301133: IGV: NPE occurs when creating a diff graph with a graph in a different folder

Koichi Sakata ksakata at openjdk.org
Fri Jan 27 06:20:23 UTC 2023


On Thu, 26 Jan 2023 08:31:30 GMT, Koichi Sakata <ksakata at openjdk.org> wrote:

> NullPointerException occurs when we create a diff graph with graphs in different folders. In this case, the graph's group doesn't have a parent. So the `getParent()` call in the Group class returns null.
> 
> A diff graph in the same folder show the text "[index] - [folder name]" in the tooltip. In this pull request, a diff graph with graphs in different folders shows the fixed string "Difference" because that string is set to the group name when a diff graph is created.
> 
> <img width="700" alt="スクリーンショット 2023-01-26 16 47 57" src="https://user-images.githubusercontent.com/60008/214790051-c236f580-3dcd-4e63-80ee-12a766736185.png">

This pull request has now been integrated.

Changeset: 938b4096
Author:    Koichi Sakata <ksakata at openjdk.org>
Committer: Tobias Hartmann <thartmann at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/938b4096086575b2bb8cc88b8985aea4bcfe314c
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8301133: IGV: NPE occurs when creating a diff graph with a graph in a different folder

Reviewed-by: rcastanedalo, chagedorn

-------------

PR: https://git.openjdk.org/jdk/pull/12214


More information about the hotspot-compiler-dev mailing list