RFR: 8301338: Identical branch conditions in CompileBroker::print_heapinfo

Tobias Hartmann thartmann at openjdk.org
Mon Jan 30 11:25:16 UTC 2023


On Mon, 30 Jan 2023 10:20:51 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> This was silently introduced by [JDK-8219586](https://bugs.openjdk.org/browse/JDK-8219586). SonarCloud complains:
>  "Identical sub-expressions on both sides of operator "||".
> 
> There are two occurrences of:
> 
>  if ((function_lock_1 != NULL) || (function_lock_1 != NULL)) {
> 
> 
> Additional testing:
>  - [x] Linux x86_64 fastdebug, `-XX:+PrintCodeHeapAnalytics` adhoc run
>  - [x] Linux x86_64 fastdebug, `compiler/codecache`

Looks good and trivial.

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12288


More information about the hotspot-compiler-dev mailing list