RFR: 8298952: All nodes should have type(n) == Value(n) after IGVN [v3]
Emanuel Peter
epeter at openjdk.org
Mon Jan 30 12:31:44 UTC 2023
On Fri, 27 Jan 2023 19:25:46 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> Ok, I can do that. I will just make a short list, and a quick sentence per item. The detailed description I will still leave further down, at the block that actually implements the exception, ok?
>
> Yes, like that. And with numbers in short list and in corresponding detailed description.
did that.
>> @vnkozlov I copied this from `TypeProfileLevel`. Should I also add the 0-check there, and change its type to `uint`?
>
> Yes, please. Both places. Otherwise it allows to specify values like `876543211` where it should be only allowed `11` max for your flag.
Done, verified manually.
-------------
PR: https://git.openjdk.org/jdk/pull/11775
More information about the hotspot-compiler-dev
mailing list