RFR: JDK-8301378: CodeHeap has virtual methods that are not overridden
Vladimir Kozlov
kvn at openjdk.org
Mon Jan 30 23:50:57 UTC 2023
On Mon, 30 Jan 2023 18:24:52 GMT, Justin King <jcking at openjdk.org> wrote:
> Remove unused `virtual` specifiers on `CodeHeap` methods. Virtual dispatch is not free in C++ and usually incurs a vtable lookup unless the compiler can prove the type is final, which with the current setup is not feasible.
Good.
This is leftover from AOT to support multiply code heaps: [aotCodeHeap.cpp#l875](https://hg.openjdk.java.net/metropolis/dev/file/01bf66b7d3bd/src/hotspot/share/aot/aotCodeHeap.cpp#l875)
-------------
Marked as reviewed by kvn (Reviewer).
PR: https://git.openjdk.org/jdk/pull/12298
More information about the hotspot-compiler-dev
mailing list