Integrated: 8301338: Identical branch conditions in CompileBroker::print_heapinfo

Aleksey Shipilev shade at openjdk.org
Tue Jan 31 11:10:04 UTC 2023


On Mon, 30 Jan 2023 10:20:51 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> This was silently introduced by [JDK-8219586](https://bugs.openjdk.org/browse/JDK-8219586). SonarCloud complains:
>  "Identical sub-expressions on both sides of operator "||".
> 
> There are two occurrences of:
> 
>  if ((function_lock_1 != NULL) || (function_lock_1 != NULL)) {
> 
> 
> Additional testing:
>  - [x] Linux x86_64 fastdebug, `-XX:+PrintCodeHeapAnalytics` adhoc run
>  - [x] Linux x86_64 fastdebug, `compiler/codecache`

This pull request has now been integrated.

Changeset: d583767b
Author:    Aleksey Shipilev <shade at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/d583767bf17aea55d361a1d1713444fc41fa9911
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

8301338: Identical branch conditions in CompileBroker::print_heapinfo

Reviewed-by: thartmann

-------------

PR: https://git.openjdk.org/jdk/pull/12288


More information about the hotspot-compiler-dev mailing list