Integrated: 8311125: Remove unused parameter 'phase' in AllocateNode::Ideal_allocation

[Xin Liu]

On Thu, 29 Jun 2023 22:46:57 GMT, Xin Liu <xliu at openjdk.org> wrote:

> There are 2 overloaded AllocateNode::Idea_allocation() in graphkit.cpp.
> One of them never uses 'phase' in the pattern-matching effort.
> 
> C++ compiler may emit a warning for the unused parameter. We will need to take care of it if we treat 
> warning as error. It also unnecessarily couple CheckCastPP with PhaseValue. In some places, we have to
> gain the instance for it. 
> 
> I would like to remove 'phase' as parameter. This is a pure clean-up. The other Idea_allocation() does 
> use PhaseValue* phase to get constant nodes, so leave it alone.

This pull request has now been integrated.

Changeset: d2e11593
Author:    Xin Liu <xliu at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/d2e11593006dc32fb8ebbaf12488b8758c8a19ee
Stats:     43 lines in 12 files changed: 0 ins; 0 del; 43 mod

8311125: Remove unused parameter 'phase' in AllocateNode::Ideal_allocation

Reviewed-by: chagedorn, kvn

-------------

PR: https://git.openjdk.org/jdk/pull/14719