RFR: 8309531: Incorrect result with unwrapped iotaShuffle. [v6]
Xiaohong Gong
xgong at openjdk.org
Mon Jul 3 08:53:01 UTC 2023
On Mon, 3 Jul 2023 07:51:20 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:
>> Patch fixes following two issues in iotaShuffle inline expander with unwrapped indices.
>> 1) Disable intrinsification if effective index do not lie within byte value range.
>> 2) Use GT predicate while computing comparison mask for all the indices above vector length.
>>
>> No performance degradation seen with existing slice/unslice operations which internally calls wrapped iotaShuffle.
>>
>> This interim patch addresses incorrectness around iotaShuffle till we introduce modified shuffle implementations
>> with JDK-8310691.
>>
>> Kindly review and share feedback.
>>
>> Best Regards,
>> Jatin
>
> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>
> Review comments resolution.
AArch64 tests pass on linux. So LGTM!
-------------
Marked as reviewed by xgong (Committer).
PR Review: https://git.openjdk.org/jdk/pull/14700#pullrequestreview-1510696799
More information about the hotspot-compiler-dev
mailing list