RFR: 8310308: IR Framework: check for type and size of vector nodes [v15]

Emanuel Peter epeter at openjdk.org
Mon Jul 3 09:37:22 UTC 2023


On Mon, 3 Jul 2023 08:06:19 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix 2 IR framework tests
>
> test/hotspot/jtreg/compiler/c2/irTests/TestVectorConditionalMove.java line 209:
> 
>> 207:                   IRNode.VECTOR_MASK_CMP_F, ">0",
>> 208:                   IRNode.VECTOR_BLEND_F, ">0",
>> 209:                   IRNode.STORE_VECTOR, ">0"},
> 
> Since "IR node count > 0" is quite a common usage, we could think about introducing a separate "hasAny" `@IR` node attribute at some point and replace all usages. But this is of course unrelated to this patch and could be done separately at some point.

It would be nice not to have to write ">0" all the time :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14539#discussion_r1250562850


More information about the hotspot-compiler-dev mailing list