RFR: 8311087: PhiNode::wait_for_region_igvn should break early [v2]
Johan Sjölen
jsjolen at openjdk.org
Tue Jul 4 10:35:21 UTC 2023
> Hi, please consider this PR.
>
> Instead of continuing the loop we break after setting `delay = true`. I also flattened out the indentation by transforming `A && B` into `!A || !B` and `continue`ing if so. This makes the code a bit longer, but clearer imho.
>
> I've run `TestCastIIAfterUnrollingInOuterLoop`, which is the test that was added along with this method. I'm also running tier1.
>
> Thanks,
> Johan
Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
Wrap continue in braces
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/14707/files
- new: https://git.openjdk.org/jdk/pull/14707/files/9dc51e1c..a327dd14
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=14707&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=14707&range=00-01
Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
Patch: https://git.openjdk.org/jdk/pull/14707.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/14707/head:pull/14707
PR: https://git.openjdk.org/jdk/pull/14707
More information about the hotspot-compiler-dev
mailing list