RFR: 8311087: PhiNode::wait_for_region_igvn should break early [v2]

[Johan Sjölen]

On Thu, 29 Jun 2023 13:15:09 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Wrap continue in braces
>
> src/hotspot/share/opto/cfgnode.cpp line 1966:
> 
>> 1964:       delay = true;
>> 1965:       break;
>> 1966:     }
> 
> Just an idea, how about putting this into a separate method `should_delay()` (or something like that) and replacing `continue` with `return false` and `break` with `return true`? If `should_delay()` is true at some point, we can push `this` to the worklist and return true.
> 
> But looks good either way.

Yeah, it could be a lambda (this isn't used anywhere else), but not sure that it'd give us too much in terms of clarity here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14707#discussion_r1251843018