RFR: 8310308: IR Framework: check for type and size of vector nodes [v18]

Tue Jul 4 11:40:24 UTC 2023

On Tue, 4 Jul 2023 11:23:29 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irrule/constraint/raw/RawCountsConstraint.java line 62:
>> 
>>> 60:         switch (comparison.getComparator()) {
>>> 61:             case "<" -> {
>>> 62:                 TestFormat.checkNoReport(comparison.getGivenValue() > 1, "Node count comparison \"<" +
>> 
>> What if `comparison.getGivenValue()` is negative?
>
> A rule like that would always fail.

Will add more checks to give more precise messages.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14539#discussion_r1251904030