RFR: 8311087: PhiNode::wait_for_region_igvn should break early [v2]

Johan Sjölen jsjolen at openjdk.org
Thu Jul 6 12:30:05 UTC 2023


On Tue, 4 Jul 2023 10:35:21 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Hi, please consider this PR.
>> 
>> Instead of continuing the loop we break after setting `delay = true`. I also flattened out the indentation by transforming `A && B` into `!A || !B` and `continue`ing if so. This makes the code a bit longer, but clearer imho.
>> 
>> I've run `TestCastIIAfterUnrollingInOuterLoop`, which is the test that was added along with this method. I'm also running tier1.
>> 
>> Thanks,
>> Johan
>
> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Wrap continue in braces

Thanks!

Integrating as only change after this was a minor style issue.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14707#issuecomment-1623591811


More information about the hotspot-compiler-dev mailing list