RFR: 8303279: C2: crash in SubTypeCheckNode::sub() at IGVN split if [v4]

[Roland Westrelin]

> The crash occurs because at split if during IGVN, a `SubTypeCheck` is
> created with null as input. That happens because the control path the
> `SubTypeCheck` is cloned for is dead. To fix that I propose delaying
> split if until dead paths are collapsed.
> 
> I added an assert to check a nullable first input to `SubTypeCheck`
> nodes (which should be impossible because it should be null
> checked). When I ran testing, a number of cases showed up with known
> non null values non properly marked as non null. I fixed them.

Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:

  review

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14678/files
  - new: https://git.openjdk.org/jdk/pull/14678/files/017d60b1..b0e3cf65

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14678&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14678&range=02-03

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/14678.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14678/head:pull/14678

PR: https://git.openjdk.org/jdk/pull/14678