RFR: 8311847: Fix -Wconversion for assembler.hpp emit_int8,16 callers

Coleen Phillimore coleenp at openjdk.org
Tue Jul 11 12:59:02 UTC 2023


On Tue, 11 Jul 2023 01:26:44 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> Please review changes to fix -Wconversion warnings that come from assembler_<cpu>.cpp by adding narrow_casts to the emit_int8,16,24, and 32 functions.  And some other fixups with checked_cast.
> 
> Ran tier1 on Oracle platforms, and tier1-4 on linux-x64-debug, linux-aarch64-debug, windows-x64-debug.

Thanks for looking at this and your help.  I think I replied to all your comments but I think there's more work to do to make this safer.

-------------

PR Review: https://git.openjdk.org/jdk/pull/14822#pullrequestreview-1524185447


More information about the hotspot-compiler-dev mailing list