RFR: 8311923: TestIRMatching.java fails on RISC-V [v2]

[Fei Yang]

On Mon, 17 Jul 2023 04:15:25 GMT, Gui Cao <gcao at openjdk.org> wrote:

>> Hi, we are experiencing test failures in test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestIRMatching.java using fastdebug:
>> 
>> 
>> One or more @IR rules failed:
>> 
>> Failed IR Rules (1) of Methods (1)
>> ----------------------------------
>> 1) Method "public java.lang.Object[] ir_framework.tests.CheckCastArray.arrayCopy(java.lang.Object[],java.lang.Class)" - [Failed IR rules: 1]:
>>    * @IR rule 1: "@compiler.lib.ir_framework.IR(phase={DEFAULT}, applyIfCPUFeatureAnd={}, applyIf={}, applyIfCPUFeatureOr={}, applyIfCPUFeature={}, counts={}, failOn={"_#CHECKCAST_ARRAYCOPY#_"}, applyIfAnd={}, applyIfOr={}, applyIfNot={})"
>>      > Phase "PrintOptoAssembly":
>>        - failOn: Graph contains forbidden nodes:
>>          * Constraint 1: "(.*((?i:call_leaf_nofp,runtime)|CALL,\\s?runtime leaf nofp|BCTRL.*.leaf call).*checkcast_arraycopy.*)"
>>            - Matched forbidden node:
>>              * 15a +   CALL, runtime leaf nofp 0x0000003f7fbd9600	#@CallLeafNoFPDirect checkcast_arraycopy
>> 
>>>>> Check stdout for compilation output of the failed methods
>> 
>> Through the description of the problem in the JBS issue, to fix this, we modified the matching rules in test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java and added the mv directive to the matching rules.
>> 
>> ## Testing:
>> qemu system and unmatched board:
>> - [x]  test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestIRMatching.java (fastdebug)
>
> Gui Cao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:
> 
>   8311923: TestIRMatching.java fails on RISC-V

LGTM.

-------------

Marked as reviewed by fyang (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14848#pullrequestreview-1532079853