RFR: 8311923: TestIRMatching.java fails on RISC-V [v3]

Gui Cao gcao at openjdk.org
Tue Jul 18 13:39:30 UTC 2023


> Hi, we are experiencing test failures in test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestIRMatching.java using fastdebug:
> 
> 
> One or more @IR rules failed:
> 
> Failed IR Rules (1) of Methods (1)
> ----------------------------------
> 1) Method "public java.lang.Object[] ir_framework.tests.CheckCastArray.arrayCopy(java.lang.Object[],java.lang.Class)" - [Failed IR rules: 1]:
>    * @IR rule 1: "@compiler.lib.ir_framework.IR(phase={DEFAULT}, applyIfCPUFeatureAnd={}, applyIf={}, applyIfCPUFeatureOr={}, applyIfCPUFeature={}, counts={}, failOn={"_#CHECKCAST_ARRAYCOPY#_"}, applyIfAnd={}, applyIfOr={}, applyIfNot={})"
>      > Phase "PrintOptoAssembly":
>        - failOn: Graph contains forbidden nodes:
>          * Constraint 1: "(.*((?i:call_leaf_nofp,runtime)|CALL,\\s?runtime leaf nofp|BCTRL.*.leaf call).*checkcast_arraycopy.*)"
>            - Matched forbidden node:
>              * 15a +   CALL, runtime leaf nofp 0x0000003f7fbd9600	#@CallLeafNoFPDirect checkcast_arraycopy
> 
>>>> Check stdout for compilation output of the failed methods
> 
> Through the description of the problem in the JBS issue, to fix this, we modified the matching rules in test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java and added the mv directive to the matching rules.
> 
> ## Testing:
> qemu system and unmatched board:
> - [x]  test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestIRMatching.java (fastdebug)

Gui Cao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'master' into JDK-8311923
 - 8311923: TestIRMatching.java fails on RISC-V

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14848/files
  - new: https://git.openjdk.org/jdk/pull/14848/files/f41ed12e..56ebf190

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14848&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14848&range=01-02

  Stats: 5647 lines in 156 files changed: 4583 ins; 541 del; 523 mod
  Patch: https://git.openjdk.org/jdk/pull/14848.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14848/head:pull/14848

PR: https://git.openjdk.org/jdk/pull/14848


More information about the hotspot-compiler-dev mailing list