RFR: 8309893: Integrate ReplicateB/S/I/L/F/D nodes to Replicate node
Cesar Soares Lucas
cslucas at openjdk.org
Wed Jul 19 04:32:44 UTC 2023
On Tue, 11 Jul 2023 14:10:25 GMT, Eric Liu <eliu at openjdk.org> wrote:
> This patch creates ReplicateNode to replace ReplicateB/S/I/L/F/DNode, like other vector nodes introduced recently, e.g., PopulateIndexNode and ReverseVNode, etc. This refers from:
> https://mail.openjdk.org/pipermail/panama-dev/2020-April/008484.html
>
> After merging these nodes, code will be easier to maintain. E.g., matching rules can be simplified.
>
> Besides AArch64, this patch tries to keep other ad files as the same before, only supplies some necessary predicate. E.g., for matching rules using ReplicateB before, they are now matching Replicate with a new predicate "Matcher::vector_element_basic_type(n) == T_BYTE". This would be easy for review and lower risks.
>
> [TEST]
> x86: Tested with option "-XX:UseAVX=0/1/2/3".
> AArch64: Tested on SVE machine and Neon machine.
>
> Full jtreg passed without new issue.
test/hotspot/jtreg/compiler/vectorization/runner/ArrayInvariantFillTest.java line 53:
> 51: private static final int SIZE = 543;
> 52:
> 53: private boolean booleanInv;
Looks like this field is not used anywhere here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14830#discussion_r1267522820
More information about the hotspot-compiler-dev
mailing list