RFR: 8308869: C2: use profile data in subtype checks when profile has more than one class [v8]

Roland Westrelin roland at openjdk.org
Wed Jul 19 07:44:44 UTC 2023


On Thu, 13 Jul 2023 16:24:09 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - never common SubTypeCheckNode nodes
>>  - keep both ways of doing profile
>
> src/hotspot/share/opto/c2_globals.hpp line 775:
> 
>> 773:           "Verify receiver types at runtime")                               \
>> 774:                                                                             \
>> 775:   product(intx, TypeProfileSubTypeCheckCommonThreshold, 50,                 \
> 
> Is it better to declare it diagnostic?

I don't have a strong opinion but the similar `TypeProfileMajorReceiverPercent` is product.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14375#discussion_r1267671141


More information about the hotspot-compiler-dev mailing list