RFR: 8312495: assert(0 <= i && i < _len) failed: illegal index after JDK-8287061 on big endian platforms

[Christoph Langer]

On Fri, 21 Jul 2023 14:24:35 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

> On big endian platforms `jint` values are stored in the high part of `StackValue` values. Therefore the the `StackValue` cannot be cast directly to `jint`. More details why this has to be like this are given in the JBS issue.
> 
> This is a common pattern. See also
> 
> https://github.com/openjdk/jdk/blob/8d29329138d44800ee4c0c02dacc01a06097de66/src/hotspot/share/runtime/deoptimization.cpp#L1386-L1387
> https://github.com/openjdk/jdk/blob/8d29329138d44800ee4c0c02dacc01a06097de66/src/hotspot/share/runtime/deoptimization.cpp#L1513-L1514
> 
> ### Testing
> Manny iterations of vmTestbase/vm/mlvm/meth/stress/compiler/sequences/Test.java.
> 
> JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. Renaissance benchmarks as functional tests.
> 
> All testing was done with fastdebug and release builds on the main platforms and also on Linux/PPC64le.

Looks good. Minor formatting comment.

src/hotspot/share/code/debugInfo.cpp line 248:

> 246:   intptr_t val = sv_selector->get_int();
> 247:   jint selector = (jint)*((jint*)&val);
> 248: 

not necessary to add a new line here

-------------

Marked as reviewed by clanger (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14976#pullrequestreview-1541864001
PR Review Comment: https://git.openjdk.org/jdk/pull/14976#discussion_r1271120352