RFR: 8312502: Mass migrate HotSpot attributes to the correct location [v2]

[Andrew Haley]

On Sun, 23 Jul 2023 05:50:58 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Someone had to do it, so I did. Moves attributes to the correct place as specified in the HotSpot Style Guide once and for all
>
> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 40 additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into patch-6
>  - arguments.hpp
>  - arguments.hpp
>  - globalDefinitions_gcc.hpp
>  - assembler_aarch64.hpp
>  - macroAssembler_aarch64.cpp
>  - vmError.cpp
>  - vmError.cpp
>  - macroAssembler_aarch64.cpp
>  - assembler_aarch64.hpp
>  - ... and 30 more: https://git.openjdk.org/jdk/compare/57f455e2...afff56f2

> Why? What is the benefit from this that makes the resulting code churn worthwhile?
> 
> We already discussed this kind of code churn a bit circa [#11081 (comment)](https://github.com/openjdk/jdk/pull/11081#issuecomment-1313274792) and didn't like it then. I don't see anything to change that.

I agree. Such changes don't much help maintainers, and speaking as the lead of both the 8u and 11u projects, really won't help backporting. I'd say no.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14969#issuecomment-1646888896