RFR: 8312502: Mass migrate HotSpot attributes to the correct location [v2]

[David Holmes]

On Sun, 23 Jul 2023 12:43:51 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> src/hotspot/share/utilities/globalDefinitions_gcc.hpp line 161:
>> 
>>> 159: #define NOINLINE     [[gnu::noinline]]
>>> 160: #define ALWAYSINLINE [[gnu::always_inline]] inline
>>> 161: #define ATTRIBUTE_FLATTEN [[gnu::flatten]]
>> 
>> This is way beyond the described scope of this PR.
>
> I changed these to the standard attributes so the compilers would concretely enforce the checks of which areas the attributes appertained to, as opposed to the regular __attribute__ syntax which don't perform such checks (Same reasoning for the ones in compilerWarnings as well)

Again I agree with Kim, this is not simply moving an attribute to a new location. It is a change that has to be validated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14969#discussion_r1271561284