RFR: 8312502: Mass migrate HotSpot attributes to the correct location [v2]

Kim Barrett kbarrett at openjdk.org
Mon Jul 24 02:36:45 UTC 2023


On Sun, 23 Jul 2023 05:50:58 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Someone had to do it, so I did. Moves attributes to the correct place as specified in the HotSpot Style Guide once and for all
>
> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 40 additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into patch-6
>  - arguments.hpp
>  - arguments.hpp
>  - globalDefinitions_gcc.hpp
>  - assembler_aarch64.hpp
>  - macroAssembler_aarch64.cpp
>  - vmError.cpp
>  - vmError.cpp
>  - macroAssembler_aarch64.cpp
>  - assembler_aarch64.hpp
>  - ... and 30 more: https://git.openjdk.org/jdk/compare/c63a77e5...afff56f2

See also:
https://openjdk.org/guide/#things-to-consider-before-proposing-changes-to-openjdk-code
This change looks like a case of pure "Modernizing", which isn't looked on
particularly favorably for its own sake. There generally needs to be some
additional benefits.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14969#issuecomment-1647108763


More information about the hotspot-compiler-dev mailing list