RFR: 8308504: C2: "malformed control flow" after JDK-8303466 [v3]

[Roland Westrelin]

On Mon, 24 Jul 2023 06:02:56 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review
>
> src/hotspot/share/opto/loopPredicate.cpp line 1519:
> 
>> 1517:     // init + (current stride - initial stride) is within the loop so narrow its type by leveraging the type of the iv Phi
>> 1518:     iv_phi_assertion_predicate_condition(loop->_head->as_CountedLoop(), new_proj, opaque_init, max_value);
>> 1519:     new_proj = add_template_assertion_predicate_helper(predicate_proj, reason, new_proj, bol, Op_If);
> 
> Shouldn't this use the the `bol` returned by `iv_phi_assertion_predicate_condition`?

Thank you for looking at this. And good catch! Some last minute refactoring gone wrong.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14973#discussion_r1272119796