RFR: JDK-8304954: SegmentedCodeCache fails when using large pages [v4]

Damon Fenacci dfenacci at openjdk.org
Mon Jul 24 14:18:46 UTC 2023


On Mon, 24 Jul 2023 12:32:06 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/codecache/CheckLargePages.java line 28:
>> 
>>> 26:  * @bug 8304954
>>> 27:  * @summary Test checks that if using large pages and code cache gets above the limit it tries to revert to smaller pages instead of failing
>>> 28:  * @requires vm.gc != "Z"
>> 
>> Why not Z?
>
> I'd limit this to linux only. No need to run on OSes that don't support large pages.
> 
> (If we want to be really correct, windows too, but I'm not so sure how stable and well-tested large page support there is)

> Why not Z?

It seems that ZGC requires large pages of specific given size (2MB. The test fails with *Incompatible -XX:LargePageSizeInBytes, only 2M large pages are supported by ZGC* otherwise).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14903#discussion_r1272328246


More information about the hotspot-compiler-dev mailing list