RFR: 8312495: assert(0 <= i && i < _len) failed: illegal index after JDK-8287061 on big endian platforms [v2]

Mon Jul 24 16:51:42 UTC 2023

On Mon, 24 Jul 2023 14:56:27 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

> I've done the the refactoring. There are a few places were I wasn't sure what to do:

Good.

> * differences in the handling of `Location::dbl` and `lng` in `reassign_fields_by_klass` and `reassign_type_array_elements`

What difference you talking about?

> * Should the logic of `StackValueCollection::float_at` and similar be moved to `StackValue`?

I think this is the case for separate RFE.

> * what to do with `byte_array_put`?

Explain please

> * Should `get_jint` be implemented as a simple (jint) cast of `_integer_value` on little endian platforms?

No. The code you suggest works for all case - there is no need to complicate it.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14976#issuecomment-1648262280