RFR: 8312596: Potential null pointer access in Compile::TracePhase::~TracePhase after JDK-8311976

Ashutosh Mehra duke at openjdk.org
Mon Jul 24 20:08:41 UTC 2023


On Mon, 24 Jul 2023 18:16:19 GMT, Ashutosh Mehra <duke at openjdk.org> wrote:

> Please review this PR to fix a potential null pointer access in using `_compile`.
> Updated the code to unconditionally initialize `_compile` and added an assert (similar to C1's `PhaseTraceTime` constructor) for it to be non-null.

windows-aarch64 builds failed with:


d:\a\jdk\jdk\src\hotspot\cpu\aarch64\assembler_aarch64.hpp(657): error C2220: the following warning is treated as an error
d:\a\jdk\jdk\src\hotspot\cpu\aarch64\assembler_aarch64.hpp(657): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)


Seems unrelated to these changes. Probably caused by this [patch](https://github.com/openjdk/jdk/commit/7dd47998f00712515c25fb852b6c0cf958120508)  @coleenp ?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15002#issuecomment-1648531829


More information about the hotspot-compiler-dev mailing list