RFR: JDK-8304954: SegmentedCodeCache fails when using large pages [v4]

[Damon Fenacci]

On Mon, 24 Jul 2023 12:50:12 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Damon Fenacci has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   JDK-8304954: merge ifs checking when to print warning
>
> test/hotspot/jtreg/compiler/codecache/CheckLargePages.java line 61:
> 
>> 59:         } else {
>> 60:             System.out.println("1GB large pages not supported: UseLargePages=" + largePages +
>> 61:                     (largePages ? ", largePageSize=" + largePageSize : "") + ". Skipping");
> 
> It would be nice to have an actual test for the downgrade. Eg if system supports 1g and 2m and 4k, check that we downgrade to 2m.

It would be nice indeed. I was looking at a way to get all page sizes available from inside the test: do you know if that is possible?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14903#discussion_r1273238212