RFR: 8312579: [JVMCI] JVMCI support for virtual Vector API objects [v2]

Gergö Barany gbarany at openjdk.org
Tue Jul 25 10:20:55 UTC 2023


On Tue, 25 Jul 2023 09:29:57 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> Gergö Barany has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Improve parameter naming
>>  - Rewrite nested ternary expressions
>
> src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/HotSpotCompiledCodeStream.java line 1036:
> 
>> 1034:     }
>> 1035: 
>> 1036:     private boolean isVector(Value vectorValue) {
> 
> `vectorValue` -> `value` (otherwise the name seems to presume a true return value)

done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15003#discussion_r1273317321


More information about the hotspot-compiler-dev mailing list