RFR: 8312547: Max/Min nodes Value implementation could be improved [v2]

[Quan Anh Mai]

On Tue, 25 Jul 2023 17:39:42 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix min/maxfp nodes
>
> src/hotspot/share/opto/addnode.cpp line 227:
> 
>> 225:   const Type *bot = bottom_type();
>> 226:   if( (t1 == bot) || (t2 == bot) ||
>> 227:       (t1 == Type::BOTTOM) || (t2 == Type::BOTTOM) )
> 
> We can  keep (t1 == Type::BOTTOM || t2 == Type::BOTTOM) condition intact.

I don't think `Type::BOTTOM` can appear here, there are other nodes (such as convert nodes) that do not check for `Type::BOTTOM`. Maybe someone could shed light on this, please?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15021#discussion_r1273943376