RFR: 8312547: Max/Min nodes Value implementation could be improved [v2]
Vladimir Kempik
vkempik at openjdk.org
Tue Jul 25 19:07:52 UTC 2023
On Tue, 25 Jul 2023 18:38:06 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:
>> Hi,
>>
>> This patch removes the early return in `AddNode::Value` in case one of the inputs is a bottom, which may affect the value calculation of nodes such as `Min/MaxNode`.
>>
>> Please kindly review, thanks very much.
>
> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>
> fix min/maxfp nodes
could you please check your change with jmh test ( numbers before and after the patch) : org/openjdk/bench/vm/compiler/MaxMinOptimizeTest.java
just want to make sure it doesn't regress
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15021#issuecomment-1650380796
More information about the hotspot-compiler-dev
mailing list