RFR: JDK-8304954: SegmentedCodeCache fails when using large pages [v4]
Damon Fenacci
dfenacci at openjdk.org
Wed Jul 26 07:12:10 UTC 2023
On Tue, 25 Jul 2023 09:33:49 GMT, Damon Fenacci <dfenacci at openjdk.org> wrote:
>> The best solution would be something like runtime/os/HugePageConfiguration, which has functions to read hugepage config directly from the OS. Unfortunately, that is package local. It may be valid to just move your test into that directory (arguably, it has to do with both code cache and huge pages, so it could be placed there too) and use it.
>>
>> Another, simpler, solution would be to scan the huge page configuration information we print at startup. -Xlog:pagesize tells you the page sizes we scan for static huge pages, and then also the page sizes we decide on using (subtly different things). That output you could scan in this test.
>
> Cool, thanks! I think I'll go for the second option.
I've made the test parse the output for page sizes and checked that the one used for code cache is the next biggest one.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14903#discussion_r1274465329
More information about the hotspot-compiler-dev
mailing list