RFR: 8312547: Max/Min nodes Value implementation could be improved [v2]

Wed Jul 26 14:13:55 UTC 2023

On Wed, 26 Jul 2023 11:30:13 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> I don't think `Type::BOTTOM` is possible here either.
>
>> I don't think `Type::BOTTOM` can appear here, there are other nodes (such as convert nodes) that do not check for `Type::BOTTOM`. Maybe someone could shed light on this, please?
> 
> Type::BOTTOM is being generated as a result of meet operations over TypeInt and other types.
> 
> With enhanced constant folding, performance should also improve significantly.

The JVM is strongly typed so I don't think anything that is not higher than the local bottom can appear here. Note that the nodes will always return the local bottom or higher on `Value` invocation.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15021#discussion_r1275019917