RFR: 8312547: Max/Min nodes Value implementation could be improved [v2]

[Vladimir Kempik]

On Tue, 25 Jul 2023 19:04:47 GMT, Vladimir Kempik <vkempik at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix min/maxfp nodes
>
> could you please check your change with jmh test ( numbers before and after the patch) : org/openjdk/bench/vm/compiler/MaxMinOptimizeTest.java
> 
> just want to make sure it doesn't regress

> @VladimirKempik Thanks for taking a look, the results look the same both before and after the patch, which is expected given none of them would benefit from more precise values of max/min nodes, these are the numbers:
> 
> ```
>                                         Before           After
> Benchmark                Mode  Cnt   Score   Error   Score   Error  Units
> MaxMinOptimizeTest.dAdd  avgt   12  59.865 ± 0.445  59.822 ± 0.323  us/op
> MaxMinOptimizeTest.dMax  avgt   12  61.109 ± 3.639  59.703 ± 0.187  us/op
> MaxMinOptimizeTest.dMin  avgt   12  59.961 ± 0.389  59.788 ± 0.281  us/op
> MaxMinOptimizeTest.dMul  avgt   12  59.477 ± 0.277  59.446 ± 0.337  us/op
> MaxMinOptimizeTest.fAdd  avgt   12  59.230 ± 0.315  59.103 ± 0.174  us/op
> MaxMinOptimizeTest.fMax  avgt   12  59.344 ± 0.422  60.171 ± 1.672  us/op
> MaxMinOptimizeTest.fMin  avgt   12  59.581 ± 0.606  59.187 ± 0.487  us/op
> MaxMinOptimizeTest.fMul  avgt   12  59.001 ± 0.236  58.948 ± 0.310  us/op
> ```

Thank you

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15021#issuecomment-1651969268