RFR: 8312235: [JVMCI] ConstantPool should not force eager resolution [v2]
Doug Simon
dnsimon at openjdk.org
Wed Jul 26 16:00:21 UTC 2023
On Wed, 26 Jul 2023 14:00:34 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:
>> Doug Simon has updated the pull request incrementally with one additional commit since the last revision:
>>
>> avoid bootstrap method invocation by lookupBootstrapMethodInfo
>
> src/hotspot/share/jvmci/jvmciCompilerToVM.cpp line 1589:
>
>> 1587: C2V_END
>> 1588:
>> 1589: C2V_VMENTRY_0(int, invokeDynamicOperandToCPIndex, (JNIEnv* env, jobject, ARGUMENT_PAIR(cp), jint operand, jboolean resolve))
>
> Is `invokeDynamicOperand` the correct name here? From what I recall, the operand to an `invokedynamic` instruction is a constant pool index which is later rewritten to an `indy_index`. I think the term operand can be confusing here.
>
> Given the way that this method works, the operand in question is always an encoded `indy_index`.
I've pushed a commit with better naming.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14927#discussion_r1275179670
More information about the hotspot-compiler-dev
mailing list