RFR: 8313141: Remove discarded volatile qualifier in assembler_aarch64.hpp [v2]
Andrew Haley
aph at openjdk.org
Thu Jul 27 08:54:41 UTC 2023
On Thu, 27 Jul 2023 04:15:06 GMT, Julian Waters <jwaters at openjdk.org> wrote:
>> ISO C++ asm is always implicitly volatile, as per https://gcc.gnu.org/onlinedocs/gcc/Basic-Asm.html, and all volatile qualifiers are always ignored if GNU asm was never used
>
> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
>
> Reference in assembler_aarch64.hpp
src/hotspot/cpu/aarch64/assembler_aarch64.hpp line 38:
> 36: #ifdef __GNUC__
> 37:
> 38: // ISO C++ asm is always implicitly volatile (https://gcc.gnu.org/onlinedocs/gcc/Basic-Asm.html)
Suggestion:
// C++ asm is always implicitly volatile (https://gcc.gnu.org/onlinedocs/gcc/Basic-Asm.html)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15031#discussion_r1275949186
More information about the hotspot-compiler-dev
mailing list