RFR: 8312596: Null pointer access in Compile::TracePhase::~TracePhase after JDK-8311976 [v3]

Christian Hagedorn chagedorn at openjdk.org
Thu Jul 27 13:43:45 UTC 2023


On Thu, 27 Jul 2023 13:38:09 GMT, Ashutosh Mehra <duke at openjdk.org> wrote:

>> Please review this PR to fix a potential null pointer access in using `_compile`.
>> Updated the code to unconditionally initialize `_compile` and added an assert (similar to C1's `PhaseTraceTime` constructor) for it to be non-null.
>
> Ashutosh Mehra has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update copyright year and remove whitespace
>   
>   Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>

Thanks for adding the test, looks good!

-------------

Marked as reviewed by chagedorn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15002#pullrequestreview-1549879961


More information about the hotspot-compiler-dev mailing list