RFR: JDK-8312617: SIGSEGV in ConnectionGraph::verify_ram_nodes [v2]

[Tobias Hartmann]

On Thu, 27 Jul 2023 18:23:30 GMT, Cesar Soares Lucas <cslucas at openjdk.org> wrote:

>> - Return early from `verify_ram_nodes` if compilation is already failing.
>> - Add back check for `failing()` after `eliminate_macro_nodes()`.
>> - Print additional diagnostic information when an unexpected user of RAM is encountered.
>> 
>> Tested with tier1-3 on Linux x64.
>
> Cesar Soares Lucas has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Refactoring use of flags.

Looks good to me otherwise. I'll run some testing and report back once it passed.

src/hotspot/share/opto/compile.cpp line 2324:

> 2322:         PhaseMacroExpand mexp(igvn);
> 2323:         mexp.eliminate_macro_nodes();
> 2324:         if (failing())  return;

Suggestion:

        if (failing()) return;

src/hotspot/share/opto/escape.cpp line 3897:

> 3895: #ifdef ASSERT
> 3896:   // At this point reducible Phis shouldn't have AddP users anymore; only SafePoints.
> 3897:   for (uint i = 0; i < reducible_merges.size(); i++ ) {

Suggestion:

  for (uint i = 0; i < reducible_merges.size(); i++) {

src/hotspot/share/opto/escape.cpp line 3900:

> 3898:     Node* phi = reducible_merges.at(i);
> 3899:     for (DUIterator_Fast jmax, j = phi->fast_outs(jmax); j < jmax; j++) {
> 3900:       Node *use = phi->fast_out(j);

Suggestion:

      Node* use = phi->fast_out(j);

-------------

Marked as reviewed by thartmann (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15048#pullrequestreview-1551986090
PR Review Comment: https://git.openjdk.org/jdk/pull/15048#discussion_r1277459478
PR Review Comment: https://git.openjdk.org/jdk/pull/15048#discussion_r1277458737
PR Review Comment: https://git.openjdk.org/jdk/pull/15048#discussion_r1277458986