RFR: 8302673: [SuperWord] MaxReduction and MinReduction should vectorize for int [v2]

Roberto Castañeda Lozano rcastanedalo at openjdk.org
Thu Jun 1 09:22:12 UTC 2023


On Wed, 31 May 2023 10:55:07 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Roberto Castañeda Lozano has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 22 additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8302673
>>  - Defer op(x, x) to constant/identity propagation early
>>  - Merge branch 'master' into JDK-8302673
>>  - Refactor idealization and extracted Identity transformation for clarity
>>  - Make auxiliary add operand extraction function return a tuple
>>  - Randomize array values in min/max test computation
>>  - Merge branch 'master' into JDK-8302673
>>  - Merge branch 'master' into JDK-8302673
>>  - Refine comments
>>  - Update copyright header
>>  - ... and 12 more: https://git.openjdk.org/jdk/compare/f05dea97...a6db3cc4
>
> src/hotspot/share/opto/addnode.cpp line 1192:
> 
>> 1190:       } else {
>> 1191:         return new MaxINode(add_transformed, inner_other);
>> 1192:       }
> 
> Could you make use of `MaxNode::build_min_max`?

Done (extracting common functionality into `build_min_max_int()`), thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13924#discussion_r1212855100


More information about the hotspot-compiler-dev mailing list