RFR: 8309104: [JVMCI] compiler/unsafe/UnsafeGetStableArrayElement test asserts wrong values with Graal [v2]

Tobias Hartmann thartmann at openjdk.org
Thu Jun 1 11:01:11 UTC 2023


On Thu, 1 Jun 2023 07:17:14 GMT, David Leopoldseder <davleopo at openjdk.org> wrote:

>> This PR fixes the UnsafeGetStableArrayElement test when run with the Graal compiler.
>> 
>> In the past this test also failed with graal because it was checking for c1/c2 semantics.
>> JDK-8264135 introduced changes to the UnsafeGetStableArrayElement test to account for the scenario when the test is run with the Graal compiler. If Graal is used it will assert that constants are folded by asserting matching instead of mismatch.
>> 
>> However, we had changes in Graal since then, since JDK-8275645 Graal no longer constant folds unaligned reads.
>> This lets the test fail again for the unaligned cases because it asserts graal folds them.
>> 
>> The fix is to actually assert mismatch on unaligned accesses.
>
> David Leopoldseder has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:
> 
>   8309104: [JVMCI] compiler/unsafe/UnsafeGetStableArrayElement test asserts wrong
>   values with Graal

Looks good.

-------------

Marked as reviewed by thartmann (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14242#pullrequestreview-1455184613


More information about the hotspot-compiler-dev mailing list