RFR: 8309295: C2: MaxNode::signed_min() returns nullptr for int operands

Tobias Hartmann thartmann at openjdk.org
Fri Jun 2 05:06:05 UTC 2023


On Thu, 1 Jun 2023 19:18:04 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

> This *trivial* changeset ensures that `MaxNode::signed_min()` returns a new `MinI` node, instead of `nullptr`, when receiving int arguments. This path is currently dead in the VM, but fixing it makes the functionality reusable (for example by JDK-8302673, currently [under review](https://github.com/openjdk/jdk/pull/13924)), more readable, and less error-prone.
> 
> #### Testing
> 
> - tier1-3 (windows-x64, linux-x64, linux-aarch64, macosx-x64, macosx-aarch64; release and debug mode).

Looks good and trivial.

-------------

Marked as reviewed by thartmann (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14272#pullrequestreview-1456651693


More information about the hotspot-compiler-dev mailing list