RFR: 8308966 Add intrinsic for float/double modulo for x86 AVX2 and AVX512 [v4]

Scott Gibbons sgibbons at openjdk.org
Fri Jun 2 18:43:10 UTC 2023


On Fri, 2 Jun 2023 18:31:24 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:

>> Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Code cleanup
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_fmod.cpp line 430:
> 
>> 428:   __ jcc(Assembler::aboveEqual, L_112a);
>> 429: //     res = y + y;
>> 430:   __ vaddsd(xmm0, xmm0, xmm1);
> 
> Should this be: __ vaddsd(xmm0, xmm1, xmm1);

This is correct as written according to the disassembly.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14224#discussion_r1214694297


More information about the hotspot-compiler-dev mailing list