RFR: 8308966 Add intrinsic for float/double modulo for x86 AVX2 and AVX512 [v2]

Jatin Bhateja jbhateja at openjdk.org
Sun Jun 4 15:36:22 UTC 2023


On Thu, 1 Jun 2023 11:00:43 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address review comments
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_fmod.cpp line 306:
> 
>> 304: 
>> 305:     Label L_104a, L_11bd, L_10c1, L_1090, L_11b9, L_10e7, L_11af, L_111c, L_10f3, L_116e, L_112a;
>> 306:     Label L_1173, L_1157, L_117f, L_11a0;
> 
> For the sake of clarity, can we segregate AVX2 functionality into a separate routine and indent the block.

Will be good to have this part in a separate routines.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14224#discussion_r1216632754


More information about the hotspot-compiler-dev mailing list