RFR: 8308966 Add intrinsic for float/double modulo for x86 AVX2 and AVX512 [v6]

Scott Gibbons sgibbons at openjdk.org
Sun Jun 4 17:21:11 UTC 2023


On Sun, 4 Jun 2023 12:05:52 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Indentation; spread source into assembly
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_fmod.cpp line 145:
> 
>> 143:     __ jcc(Assembler::equal, L_5280);
>> 144:     //     if (eq >= 0x7fefffffu) goto SPECIAL_FMOD;
>> 145:     __ cmpl(rax, 0x7feffffe);
> 
> Comment mention comparison against 0x7feffff.

This is an artifact of block reordering by the compiler and should be correct.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14224#discussion_r1216929285


More information about the hotspot-compiler-dev mailing list