Integrated: 8309405: RISC-V: is_deopt may produce unaligned memory read
Vladimir Kempik
vkempik at openjdk.org
Mon Jun 5 07:33:15 UTC 2023
On Sat, 3 Jun 2023 12:34:20 GMT, Vladimir Kempik <vkempik at openjdk.org> wrote:
> Please review this simple fix, a continuation of JDK-8291550.
>
> Doing some profiling for trp_lam event (misaligned load emulation) on fpga I've found some more misaligned loads, pretty rare but still happens.
> Here, is_deopt directly dereferences memory address, but with RVC enabled, a single 4-byte intruction could be 2-bytes, but not 4-bytes aligned.
> So is_deopt should use ld_instr to be on safe side.
>
> Testing: tier1 on hifive clean.
This pull request has now been integrated.
Changeset: a02d8001
Author: Vladimir Kempik <vkempik at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/a02d8001fa43b379bee3803cda06a15a64d99ac2
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
8309405: RISC-V: is_deopt may produce unaligned memory read
Reviewed-by: fyang, luhenry
-------------
PR: https://git.openjdk.org/jdk/pull/14299
More information about the hotspot-compiler-dev
mailing list