RFR: JDK-8309410: [aarch64] Use pre-computed tables for logical immediates

Thomas Stuefe stuefe at openjdk.org
Mon Jun 5 10:00:15 UTC 2023


On Mon, 5 Jun 2023 09:47:37 GMT, Andrew Haley <aph at openjdk.org> wrote:

> > My proposal was an incremental improvement and it deliberately does not touch the table format and the decoding. If you think it is not worth it, I'll close it - this was just a small improvement and there is no time for more.
> 
> I really don't know one way or another. I am sure, however, that for this patch to be complete it _must_ include the code used to generate the table, and that's a significant bump in complexity.

True. We can add this code separately from hotspot though, e.g. as python script.

But since I don't have any more time to spend, I'll shelve it for now. Also, maybe there is a way to compute the encoding from the immediate bit pattern; it cannot be that hard. Maybe that's the better way to go.

Anyway, thanks for looking at this!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14304#issuecomment-1576489841


More information about the hotspot-compiler-dev mailing list