RFR: 8302145: ddepth should be uint in PhaseIdealLoop::register_node()

Tobias Hartmann thartmann at openjdk.org
Wed Jun 7 05:46:57 UTC 2023


On Tue, 6 Jun 2023 12:50:50 GMT, Eric Nothum <duke at openjdk.org> wrote:

> Changed the type of the ddepth parameter in PhaseIdealLoop::register_node from int to uint, to avoid potentially unsafe uint -> int casts.
> The method is often used with uint arguments, coming from dom_depth().
> I have verified the calls of PhaseIdealLoop::register_node and have removed related casts.

Looks good to me.

-------------

Marked as reviewed by thartmann (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14333#pullrequestreview-1466652442


More information about the hotspot-compiler-dev mailing list