RFR: 8309472: IGV: Add dump_igv(custom_name) for improved debugging

Tobias Hartmann thartmann at openjdk.org
Wed Jun 7 05:48:56 UTC 2023


On Mon, 5 Jun 2023 14:16:44 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

> When debugging, I often add multiple IR dumps throughout the code to capture different states. To do that, I'm just re-using various `PHASE_XYZ` `CompilerPhaseType` enum values:
> 
> Compile::current()->print_method(PHASE_END, 3);
> 
> But this becomes confusing when using multiple such enum values and trying to remember what they actually mean. To overcome that (and to avoid creating new enum values each time), I suggest to introduce a new `dump_igv(custom_name)` method where `custom_name` can be an arbitrary string. Then we can use the following when debugging:
> 
> Compile::current()->dump_igv("foo");
> Compile::current()->dump_igv("bar");
> 
> Thanks,
> Christian

Looks good.

-------------

Marked as reviewed by thartmann (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14313#pullrequestreview-1466654129


More information about the hotspot-compiler-dev mailing list