RFR: 8309562: [JVMCI] Export symbols used by VirtualThread notifyJvmti intrinsics to JVMCI compilers. [v2]

Wed Jun 7 16:16:01 UTC 2023

On Wed, 7 Jun 2023 15:39:30 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Yudi Zheng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   address comment.
>
> src/hotspot/share/jvmci/vmStructs_jvmci.cpp line 222:
> 
>> 220:   JVMTI_ONLY(nonstatic_field(JavaThread,       _is_in_tmp_VTMS_transition,                    bool))                                 \
>> 221:                                                                                                                                      \
>> 222:   static_field(JvmtiVTMSTransitionDisabler,    _VTMS_notify_jvmti_events,                     bool)                                  \
> 
> I think this should be also under `JVMTI_ONLY()`. Did you have issues if you do that?

No. Thought it was accessible without JVMTI. Thanks for pointing this out, I have pushed an update.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14348#discussion_r1221861206