RFR: 8307683: Loop Predication should not hoist range checks with trap on success projection by negating their condition [v4]

Christian Hagedorn chagedorn at openjdk.org
Mon Jun 12 09:05:00 UTC 2023


On Mon, 12 Jun 2023 05:12:01 GMT, Harry Dinh <duke at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Update src/hotspot/share/opto/loopPredicate.cpp
>>    
>>    Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>>  - Update test/hotspot/jtreg/compiler/predicates/TestHoistedPredicateForNonRangeCheck.java
>>    
>>    Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>
> May I know if the fix applied to jdk11 as well? 
> 
> We got the same issue with jdk11.0.19.

@hungk20 The negation of the condition for range checks was introduced in [JDK-7173584](https://bugs.openjdk.org/browse/JDK-7173584) which went into JDK 9. Therefore, JDK 11u is also affected. You could either backport this fix or backout [JDK-8297951](https://bugs.openjdk.org/browse/JDK-8297951) (see [JDK-8308884](https://bugs.openjdk.org/browse/JDK-8308884)).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14156#issuecomment-1586896163


More information about the hotspot-compiler-dev mailing list