RFR: 8309613: [Windows] hs_err files sometimes miss information about the code containing the error [v4]

[Martin Doerr]

On Tue, 13 Jun 2023 06:02:24 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improve output string.
>
> src/hotspot/share/runtime/os.hpp line 1011:
> 
>> 1009:  public:
>> 1010:   inline static bool platform_print_native_stack(outputStream* st, const void* context,
>> 1011:                                                  char *buf, int buf_size);
> 
> Small nit, can we make this not a reference, but a pointer, and make it optional and possibly default it to nullptr?

Then, we should probably name it `lastpc_ptr`? Would that really be better? I'm not conviced.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14358#discussion_r1227827772